Skip to content

Update SwiftBuild progress reporting #9519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bripeticca wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Update SwiftBuild progress reporting #9519

bripeticca wants to merge 12 commits into from

Conversation

@bripeticca
Copy link
Contributor

@bripeticca bripeticca commented Dec 16, 2025 •
edited
Loading

Addresses:

  • Comments under Capture code snippet from diagnostic compiler output #9362 related to testing
  • Removes the stepping fraction from being printed when dealing with events that report a negative percentage; the idea here is that if the progress is in the negative, this seems to be a pre-build step where there is no real benefit to reporting the "percentage complete" here.
  • Omit messages that do not contain useful information (i.e. messages that are of the format "14 / 27" without any identifying text, etc.)
  • Emit planning operation start + complete in a similar fashion to the native build system
  • Emit instances of a target being already up to date and not requiring a build.

jakepetroules
jakepetroules reviewed Jan 12, 2026
View reviewed changes
Sources/SwiftBuildSupport/SwiftBuildSystemMessageHandler.swift Outdated
}
case .targetUpToDate(let info):
// Received when a target is entirely up to date and did not need to be built.
self.outputStream.send("Target \(info.guid) up to date." + "\n")
Copy link
Contributor

@jakepetroules jakepetroules Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be under isVerbose or perhaps even extra verbose.

Copy link
Contributor Author

@bripeticca bripeticca Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed - I just updated this line to self.observabilityScope.emit(info: ...) so it should be visible only under verbose mode now.

@bripeticca
Copy link
Contributor Author

bripeticca commented Jan 12, 2026

@swift-ci please test

@bripeticca bripeticca changed the title [WIP] Update SwiftBuild progress reporting Update SwiftBuild progress reporting Jan 12, 2026
@bripeticca bripeticca marked this pull request as ready for review January 12, 2026 22:54
@bripeticca
Copy link
Contributor Author

bripeticca commented Jan 14, 2026

@swift-ci please test

1 similar comment
@bripeticca
Copy link
Contributor Author

bripeticca commented Jan 16, 2026

@swift-ci please test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakepetroules jakepetroules jakepetroules left review comments

@dschaefer2 dschaefer2 Awaiting requested review from dschaefer2 dschaefer2 is a code owner

@plemarquand plemarquand Awaiting requested review from plemarquand plemarquand is a code owner

@owenv owenv Awaiting requested review from owenv owenv is a code owner

@bkhouri bkhouri Awaiting requested review from bkhouri bkhouri is a code owner

@cmcgee1024 cmcgee1024 Awaiting requested review from cmcgee1024 cmcgee1024 is a code owner

@daveyc123 daveyc123 Awaiting requested review from daveyc123 daveyc123 is a code owner

@rconnell9 rconnell9 Awaiting requested review from rconnell9 rconnell9 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bripeticca @jakepetroules